-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lidar_transfusion): intensity as uint8 and tests #7745
base: main
Are you sure you want to change the base?
feat(lidar_transfusion): intensity as uint8 and tests #7745
Conversation
Signed-off-by: Amadeusz Szymko <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Amadeusz Szymko <[email protected]>
@amadeuszsz I did something similar here: |
Note: |
FYI we already checking first input cloud and comparing with the reference. |
🙈 For example, |
@amadeuszsz |
Removing |
Sorry, I did not understand what you meant. Btw, what failed to compile was a local build in my PC
|
…factor Signed-off-by: Amadeusz Szymko <[email protected]>
Signed-off-by: Amadeusz Szymko <[email protected]>
Signed-off-by: Amadeusz Szymko <[email protected]>
Signed-off-by: Amadeusz Szymko <[email protected]>
If we switch this PR to draft, the review will take place after merge of parent PR.
My fault, I should leave a note that this PR required changes from parent PR. Required changes are not included since parent PR is still under development. For time being I'm using |
Signed-off-by: Amadeusz Szymko <[email protected]>
Signed-off-by: Amadeusz Szymko <[email protected]>
Description
This PR updates intensity field as it's considered in new Autoware point clouds format. New unit tests cover this change.
Related links
Parent Issue:
Parent PR:
How was this PR tested?
Notes for reviewers
Changes from parent PR are required to build & test this PR.
Interface changes
Now the input point cloud has to contain uint8 intensity field.
Effects on system behavior
None.