Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(image_projection_based_fusion): handle projection errors in image fusion nodes #7747

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+49 −11

fix: handle projection errors in image fusion nodes

3268716
Select commit
Loading
Failed to load commit list.
Open

fix(image_projection_based_fusion): handle projection errors in image fusion nodes #7747

fix: handle projection errors in image fusion nodes
3268716
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jun 28, 2024 in 41s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method node.cpp: RoiClusterFusionNode::fuseOnSingleImage
  • Complex Method node.cpp: RoiDetectedObjectFusionNode::generateDetectedObjectRoIs

Annotations

Check warning on line 143 in perception/image_projection_based_fusion/src/roi_cluster_fusion/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

RoiClusterFusionNode::fuseOnSingleImage increases in cyclomatic complexity from 42 to 43, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 157 in perception/image_projection_based_fusion/src/roi_detected_object_fusion/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

RoiDetectedObjectFusionNode::generateDetectedObjectRoIs increases in cyclomatic complexity from 20 to 21, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis