Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autodiff: improve the Graphviz visualisations. #74

Open
2 tasks
avhz opened this issue Jul 15, 2023 · 4 comments
Open
2 tasks

autodiff: improve the Graphviz visualisations. #74

avhz opened this issue Jul 15, 2023 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@avhz
Copy link
Owner

avhz commented Jul 15, 2023

There are problems with the Graphviz plotting of the computation graphs in autodiff:

  • The nodes don't indicate the operation that took place (e.g. +, sin).
  • There are double links from one node to others (e.g. input x1 has two edges to Op_3).
    • The edge should not be drawn if the weight is 0.

graphviz

@avhz avhz added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jul 15, 2023
@nicola-corbellini
Copy link

Hello! Along my path to start learning Rust I've come across your repository and I'd like to tackle this issue if it's not out of the scope of my current skills.

May I ask for a hint? Where could I get the operation performed on the input? I haven't found it available either in the Variable nor in the Graph. Thank you

@avhz
Copy link
Owner Author

avhz commented Sep 4, 2023

Hi thanks for the interest!
Unfortunately there's no current way to retrieve the operation performed, and this would need to be added.

@JainVidit12
Copy link

Created Pull request #131 to address this.

@0xJepsen
Copy link
Contributor

Might i recommend the plotters library as well? We have used it quite a bit and found it to be really good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
No open projects
Status: No status
Development

No branches or pull requests

4 participants