Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builder #18

Open
ayazhafiz opened this issue Jul 18, 2020 · 1 comment
Open

Builder #18

ayazhafiz opened this issue Jul 18, 2020 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ayazhafiz
Copy link
Owner

ayazhafiz commented Jul 18, 2020 •
edited
Loading

It would be nice to have a Builder struct that allows for convenient collection of keys before creating a filter (any of the xor filters or a HashProxy) with those keys.
@ayazhafiz ayazhafiz added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 18, 2020
@CKingX
Copy link

CKingX commented Jun 20, 2022

I could help with this!

We could use a HashMap behind the scenes (will also ensure we don't have any duplicates). I will work on a PR soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CKingX @ayazhafiz