Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion to update read me and add couple of signals to improve plugin #61

Open
YehudaK opened this issue Oct 7, 2017 · 0 comments
Open

Comments

@YehudaK
Copy link

YehudaK commented Oct 7, 2017

It's worth to mention in read me that text for such input should be set only via "setText()" method. Otherwise, once stage gets any tap, contents of input is automatically erased (since dom input is empty). Also reading data from input should be done via "value" property.

Finally, it will be just couple of lines of code to add two more signals: onFocusIn and onFocusOut which developers could use to handle when user finished typing... as you do not trigger keyboard closed for desktop intentionally (which has no reason, unless you intentionally do not want people use your code).

Thanks

p.s. if you need, I can tell you where to make changes or even modify parser-input.js file. I can make pull requests if needed but I prefer native git repositories rather github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant