Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting annotations on VolumeSnapshots #235

Open
timstoop opened this issue Sep 21, 2022 · 0 comments
Open

Allow setting annotations on VolumeSnapshots #235

timstoop opened this issue Sep 21, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@timstoop
Copy link

Describe the feature you'd like to have.

We would like to be able to set standard annotations on VolumeSnapshots. Currently, only setting labels is allowed.

What is the value to the end user? (why is it a priority?)

Being able to set annotations allows for better integration with other tools. For instance, when you only want to keep VolumeSnapshots around for at most 60 days, you could set an annotation that is picked up by kube-janitor to automatically remove the snapshot after it's 60 days old. I can imagine other tools exist that would be able to make use of annotations instead of labels.

How will we know we have a good solution? (acceptance criteria)

Annotations can be part of the VolumeSnapshotTemplate.

Additional context

In our case, we already use kube-janitor a lot and we only want to keep snapshots around for at most 30 days. Although I can imagine some people would prefer to have that expiration option build into snapscheduler, I think it would be easier to implement allowing annotations in the VolumeSnapshotTemplate instead, as I can imagine that would solve other issues as well and kinda makes sense as well to allow it when labels are also allowed.

@timstoop timstoop added the enhancement New feature or request label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant