Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISCUSSION] Allow deeplink to set source and target amount for /trade/market #1501

Open
tiagofilipenunes opened this issue Sep 19, 2024 · 0 comments

Comments

@tiagofilipenunes
Copy link
Collaborator

As part of removing the source and target amounts from the /trade/market path, there was a question raised about allowing these amounts to instead be used in the spot trade.

When trading spot in the /trade/market page, is it desirable to allow users to share a deeplink which populates the source or target values?

Something like https://app.carbondefi.xyz/trade/market?base=0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE&quote=0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48&source=1&target=2&tradeByTarget=false&direction=buy

Would use the source amount = 1 and populate it in the ETH/USDC buy trade for 1 USDC.

Notes

  • Users might share a link with an amount that no longer makes sense - either because there's no more liquidity or there's not enough wallet balance for the trade in the first place.
  • Is there a usecase for this feature?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant