Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a checksum for flashloan and target tokens to prevent filtering #637

Open
NIXBNT opened this issue May 8, 2024 · 0 comments
Open

Add a checksum for flashloan and target tokens to prevent filtering #637

NIXBNT opened this issue May 8, 2024 · 0 comments
Assignees
@NIXBNT
Labels
enhancement New feature or request

Comments

@NIXBNT
Copy link
Collaborator

NIXBNT commented May 8, 2024

Enhancement Description

If the user inputs a token address that is not checksummed into the flashloan token or target token field it will be filtered out at a later point in the process.
To improve user experience a checksum should be run over input addresses

Rationale

Improve user experience

Impact Analysis

  • Automated Tests: Implications on testing (new/changed)
  • Risks: What are the risks associated with this enhancement?
  • Performance: Expected performance impacts and how to measure them
  • Monitoring: Changes required in the monitoring system
  • Logging: Do we need additional logs?
  • Documentation: Updates or new documentation needed?
@NIXBNT NIXBNT added the enhancement New feature or request label May 8, 2024
@NIXBNT NIXBNT self-assigned this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NIXBNT NIXBNT

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

637-add-a-checksum-for-flashloan-and-target-tokens-to-prevent-filtering bancorprotocol/fastlane-bot
1 participant
@NIXBNT