Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Earn table - Pool data drop-menu #633

Open
ashachaf opened this issue Aug 23, 2022 · 0 comments
Open

Earn table - Pool data drop-menu #633

ashachaf opened this issue Aug 23, 2022 · 0 comments
Labels
enhancement New feature or request PRIORITY Prioritized issues

Comments

@ashachaf
Copy link
Collaborator

ashachaf commented Aug 23, 2022

as a user, i would like to have more information about the pool to include liquidity figures and activity.

High level

Replacing the tooltip with a more enrich menu to earn table

We are not changing anything on the earn table only adding the menu

Pool data menu

Design

mockup:

https://www.figma.com/file/fwADI9wqDrRAdlMX8EddCw/Bancor-v3?node-id=16555%3A244719

  • Replace the old tooltip with the new menu element
  • Add an chevron icon (Close/Open) next to the token name

Screen Shot 2022-08-28 at 10 37 19

Menu data and tooltips

  • Name - Staked balance
  • API - stakedBalance.usd
  • Tooltip - The amount users have deposited and earned in fees
  • Name - Trading liquidity
  • API - tradingLiquidityTKN.usd
  • Tooltip - The amount of liquidity that is available for trading
  • Name - Volume 24h
  • API - volume24h.usd
  • Name - Pool fees 24h
  • API - fees24h.usd
  • Name - LP fees 24h
  • API - fees24h.usd - networkFees24.usd
  • Name - Vault balance
  • API - liquidity.usd
  • Tooltip - The amount of tokens currently available
  • Name - Vault balance %
  • Calculation - {(liquidity+externalIlVault)/ stakedBalance * 100}
externalIlVault
we want to include any external protected that was provided by the team into the available liquidity.
this is the same data used in point 8 below.
https://etherscan.io/address/0xfd31662b3d54edde9b6bdd32c9c27c8e292cad57
isPaused = False, getBalance(token) in the contract to identify the amount available and should be included in the available liquidity
  • Deficit mark in red / Surplus mark in blue and add "Surplus" to the right side of the %
  • Tooltip - The % of tokens currently available
  • Name - External Liquidity protection
  • Vault Contract - 0xFd31662b3d54eddE9B6Bdd32c9c27C8E292cAD57
  • Show only if - isPaused = False and there is balance for the specific token
  • Tooltip - The amount available to compensate for pool deficits during a withdrawal, provided by {Sponsor name}
@ashachaf ashachaf added the enhancement New feature or request label Aug 23, 2022
@ashachaf ashachaf self-assigned this Aug 23, 2022
@Yanivshechter1 Yanivshechter1 self-assigned this Aug 24, 2022
@Yanivshechter1 Yanivshechter1 changed the title earn table - enrich pool data tool tip Earn table - Pool data drop-menu Aug 25, 2022
@ashachaf ashachaf added the PRIORITY Prioritized issues label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PRIORITY Prioritized issues
Projects
None yet
Development

No branches or pull requests

2 participants