Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revoke UI #727

Open
Costa769 opened this issue Apr 23, 2023 · 0 comments
Open

Revoke UI #727

Costa769 opened this issue Apr 23, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Costa769
Copy link
Collaborator

We need to change the UI of the approval popup in cases when the selected token requires revoke spending cap ( approve 0). The new UI will explain to the user not to change the amount from 0 to another value.

Wallet types:
Metamask user- Display new approve popup UI
TrustWallet, Coinbase wallet, etc- No change(current approve popup UI)

In case the token requires revoke(approve 0) before setting a new spending cap , the following changes will be made to the approval popup

  1. Change the text above the CTA to "Before updating {token} allowance, you are required to revoke it to 0"
  2. Change CTA text to "Revoke and Approve"
  3. Remove text below the CTA

Current approve popup
image

Revoke+Approve popup
image

see Carbon reference task below:
bancorprotocol/carbon-app#546

@Costa769 Costa769 added the enhancement New feature or request label Apr 23, 2023
@pingustar pingustar assigned pingustar and unassigned ashachaf Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants