Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong reversed transliteration for some Greek capital letters #52

Open
GianniGT opened this issue Nov 8, 2019 · 1 comment
Open

Wrong reversed transliteration for some Greek capital letters #52

GianniGT opened this issue Nov 8, 2019 · 1 comment
Labels

Comments

@GianniGT
Copy link

GianniGT commented Nov 8, 2019

The reversed_specific_mapping tuple for Greek contains only lower case letters:

reversed_specific_mapping = (
u"ςάέήίύόώϊϋΐΰωΩηΗϵϱ",
u"saeiiyooiyiyooiier"
)

the reverse transliteration of capital Greek letters doesn't work. For instance the capital letter Ϊ is not transliterated.

A possible fix is to programmatically add the capital version of each symbol in base.py with something like this:
(...)

        _for key, val in zip(self.reversed_specific_mapping[0].**upper()**, self.reversed_specific_mapping[1].**upper()**):
            self.reversed_specific_translation_table.update(
                {ord(key): ord(val)}
            )_
@barseghyanartur
Copy link
Owner

barseghyanartur commented Dec 14, 2019

@GianniGT

Thanks for bringing this up.

There have been numerous attempts and PRs to bring corectness to Greek transliteration.

I'm all open for correctness and thus willing to accept a valid PR.

I think back in the day, I have used this Wikipedia article as a valid and trustworthy source of information on the topic.

Could you please double check your findings with the mentioned Wikipedia article and let me know if current interpretation of transliterate isn't correct?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants