From 4e73650a1386b7cf3d416969db9cf8008aa9efe0 Mon Sep 17 00:00:00 2001 From: albu Date: Wed, 19 Dec 2018 12:45:47 -0500 Subject: [PATCH 1/2] fix wrong returnAttrs --- cognito-user-pool-client/index.js | 30 ++++++++++++------------------ 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/cognito-user-pool-client/index.js b/cognito-user-pool-client/index.js index 097e505..5ad77ce 100644 --- a/cognito-user-pool-client/index.js +++ b/cognito-user-pool-client/index.js @@ -9,6 +9,15 @@ let AWS = require('aws-sdk'), apiVersion: '2016-04-18' }); +function returnedData(data) { + return { + 'ClientId': data.UserPoolClient.ClientId, + 'CreationDate': data.UserPoolClient.CreationDate, + 'LastModifiedDate': data.UserPoolClient.LastModifiedDate, + 'ClientSecret': data.UserPoolClient.ClientSecret + } +} + let logic = { Create: CfnLambda.SDKAlias({ api: CognitoApi, @@ -33,24 +42,14 @@ let logic = { 'SupportedIdentityProviders', 'WriteAttributes' ], - returnAttrs: [ - 'UserPoolClient.ClientId', - 'UserPoolClient.CreationDate', - 'UserPoolClient.LastModifiedDate', - 'UserPoolClient.ClientSecret' - ], + returnAttrs: returnedData, returnPhysicalId: 'UserPoolClient.ClientId' }), DoUpdate: CfnLambda.SDKAlias({ api: CognitoApi, method: 'updateUserPoolClient', - returnAttrs: [ - 'UserPoolClient.ClientId', - 'UserPoolClient.CreationDate', - 'UserPoolClient.LastModifiedDate', - 'UserPoolClient.ClientSecret' - ], + returnAttrs: returnedData, physicalIdAs: 'ClientId', keys: [ 'UserPoolId', @@ -84,12 +83,7 @@ let logic = { logic.NoUpdate = CfnLambda.SDKAlias({ api: CognitoApi, method: 'describeUserPoolClient', - returnAttrs: [ - 'UserPoolClient.ClientId', - 'UserPoolClient.CreationDate', - 'UserPoolClient.LastModifiedDate', - 'UserPoolClient.ClientSecret' - ], + returnAttrs: returnedData, physicalIdAs: 'ClientId', keys: [ 'UserPoolId', From 7248887e943de6086b9d6d4751afe4e8bba88d43 Mon Sep 17 00:00:00 2001 From: albu Date: Wed, 19 Dec 2018 16:40:19 -0500 Subject: [PATCH 2/2] fix the same for returnPhysicalId --- cognito-user-pool-client/index.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cognito-user-pool-client/index.js b/cognito-user-pool-client/index.js index 5ad77ce..6a51c90 100644 --- a/cognito-user-pool-client/index.js +++ b/cognito-user-pool-client/index.js @@ -43,7 +43,9 @@ let logic = { 'WriteAttributes' ], returnAttrs: returnedData, - returnPhysicalId: 'UserPoolClient.ClientId' + returnPhysicalId: function(data) { + return data.UserPoolClient.ClientId + } }), DoUpdate: CfnLambda.SDKAlias({