Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch refactors the C++ compilation actions in
CcCompilationHelper
. It introduces a helper methodcreateSourceActionHelper
to streamline the creation of source actions and reduces duplicated code related to PIC and non-PIC compilation.Changes
Refactored Source Action Creation:
createSourceActionHelper
to handle the common logic for creating compile actions.Updated
createSourceAction
Method:createSourceAction
method now callscreateSourceActionHelper
for both PIC and non-PIC compile actions.createSourceAction
method and removes redundancy.Benefits
Background
I'm working on support C++20 Modules in Bazel, see #19940
While constructing the action graph for compiling C++20 Modules, I noticed that the
createSourceAction
code could be reused. Therefore, I refactoredcreateSourceAction
. One potentially unusual aspect is the handling ofArtifactCategory.CPP_MODULE
at the end. Since the logic for handling C++20 Modules differs from that of Clang Modules, this part of the logic was placed outside ofcreateSourceActionHelper
.the code of constructing the action graph for compiling C++20 Modules is #22553