Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection avatar downgraded to HTTP #45

Open
ChaosExAnima opened this issue Sep 11, 2019 · 0 comments
Open

Connection avatar downgraded to HTTP #45

ChaosExAnima opened this issue Sep 11, 2019 · 0 comments

Comments

@ChaosExAnima
Copy link

This is related to #17 and #18. The code to display connection avatars uses set_url_scheme, which changes the scheme based off of the current site configuration. However, in many cases that would mean that the avatar is downgraded to HTTP when HTTPS is available, or even in the case of Google's avatars where a non-SSL version is not available.

I would propose instead that the following logic:

  • If the avatar is HTTPS, keep the URL unchanged.
  • If the avatar is HTTP, add a filter or other method to allow services to declare SSL should be forced. If this is set to true, set the schema to HTTPS.
  • If the service did not opt in, use the current logic.

Happy to contribute a PR if desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant