-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation #29
Comments
I think As for the imports, I added the full path in order to easily build the package for uploading to PyPI. I added the following to
If that doesn't work, you might try experimenting to get Python find the right path to the modules. |
Sounds good! I think I fixed the issue by adding |
Seems to be working great! |
Ran into an issue trying to use the package with the |
I was able to build the package successfully. I haven't tried uploading it to PyPI just yet but assume that wouldn't present any further issue. But I'll look out for that on the next upload. |
Hey Ben, I've been taking a look at the refactoring and it looks great! I like the idea of a StateSpace object. (I made a new issue because I didn't want to clutter the old Data Structure issue)
I've been adding documentation and comments here and there, and there's a couple things I'd let you know:
make_constraints
todefine_N_semantics
. My reasoning was thatmake_constraints
doesn't actually make the constraints, it makes the function that makes the constraints (something that was even in the docstring for the function lol). So I gave it that other name—if you think of something else feel free to change it, but just thought that change may help things be more clear.model_structure
. Is there a reason they weremodel_checker.____
as opposed to just being____
?The text was updated successfully, but these errors were encountered: