Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing library(cmprsk) from test files #52

Open
michaelquinn32 opened this issue Dec 2, 2022 · 1 comment
Open

Consider removing library(cmprsk) from test files #52

michaelquinn32 opened this issue Dec 2, 2022 · 1 comment

Comments

@michaelquinn32
Copy link

Hi David!

I hope all is well.

There are two test files that have library calls to suggested packages:

I was able to remove these calls from the file without tests failing. Are they spurious?

Otherwise, could you consider a non-failing condition for these? Something like require() or skip_if_not_installed().
https://testthat.r-lib.org/reference/skip.html

Thanks!

@michaelquinn32
Copy link
Author

Wait, there is a case in tests/testthat/test-hazrd_tmle.R that relies on the cuminc function. It would be nice to wrap that in a skip_if_not_installed().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant