Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude built plugins/themes from build process. #37

Open
ampersarnie opened this issue May 18, 2022 · 1 comment
Open

Exclude built plugins/themes from build process. #37

ampersarnie opened this issue May 18, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ampersarnie
Copy link
Member

ampersarnie commented May 18, 2022

When including a plugin or theme from a release that has build assets and the src directory still intact, the build tools will still attempt to compile and add those entrypoints to its process and list of projects to be compiled. These types of projects are not something we should be targeting for build when running through a compile process and need to be excluded unless explicitly stated.

Originally flagged as an issue here: https://github.com/bigbite/block-footnotes/issues/36

@ampersarnie ampersarnie self-assigned this May 18, 2022
@ampersarnie ampersarnie added this to the v1.1 milestone May 18, 2022
@ampersarnie ampersarnie added the bug Something isn't working label May 18, 2022
@ampersarnie ampersarnie modified the milestones: v1.1, v1.2 Dec 12, 2022
@g-elwell
Copy link
Member

@ampersarnie there was an issue with our CI that meant files listed in deployignore weren't being removed when creating a built branch for a project.

Since this is now fixed, this issue may be dependent on whether you feel we should be excluding src directories from builds or not.

@ampersarnie ampersarnie modified the milestones: v1.2, v1.3 Mar 30, 2023
@ampersarnie ampersarnie removed this from the v1.3 milestone Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To do
Development

No branches or pull requests

2 participants