-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for declaring specific endpoints to be built #120
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Connor! Works for me 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not tested yet and only reviewed code. Looks great, I've left some minor feedback for you. Also, can you update the docs in docs/
with how this works to provide guidance to users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go after these are removed.
example-site/yarn.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just spotted this, yarn isn't used in the project so can this be removed to avoid confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this :)
yarn.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just spotted this, yarn isn't used in the project so can this be removed to avoid confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this :)
Description
This PR adds the ability to define the endpoints you want to build so that if your working on a specific part of a project you can optimise performance/speed of builds for what your working on via defining the endpoints after
@
symbol. For example for all projects you can use@frontend
or if your working with multiple project and only want to build the frontend assets for one you can usetest-plugin@frontend
. Fixes #46Change log
projects
positional can have entrypoints defined after them by appened@
along with the entrypoint ietest-plugin@frontend
or multiple via+
such astest-plugin@frontend+editor
.filteredEntrypoints
which will contain the specified entrypoints if set, defaults to empty array.getFilteredEntryPoints
).Code reviewer(s)
filteredEntrypoints
the right variable name?plugin@fronted+editor
,@frontend
, etc)?README.md
will be updated once an initial review has been done and the above questions have been answered as things are subject to change.Testing
Example Individual Projects build command:
build-tools build my-plugin@frontend
.Example Site-wide build command:
build-tools build @frontend
.@
specified@frontend
specified@frontend+editor
specified@
specified@frontend
specified@frontend+editor
specified