Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG | K8s node group max/min definition for "spot" group is omitted #482

Open
juanmatias opened this issue Mar 7, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@juanmatias
Copy link
Contributor

Describe the Bug

In the k8s-eks/cluster layer, in eks-managed-nodes.tf file this definition is set:

eks_managed_node_groups = {
on-demand = {
min_size = 1
max_size = 3
desired_size = 1
capacity_type = "ON_DEMAND"
instance_types = ["t2.medium", "t3.medium"]
}
spot = {
desired_capacity = 1
max_capacity = 3
min_capacity = 1
capacity_type = "SPOT"
instance_types = ["t2.medium", "t3.medium"]
}
}

As it can be seen in the documentation for the module here:

  eks_managed_node_groups = {
    blue = {}
    green = {
      min_size     = 1
      max_size     = 10
      desired_size = 1

      instance_types = ["t3.large"]
      capacity_type  = "SPOT"
    }
  }

only max_size and min_size is accepted, while max_capacity and min_capacity are not taken into account when applying the module.

So, in the example from the RefArch the values in max_capacity and min_capacity are not used, instead defaults are used for max_size and min_size.

Expected Behavior

The max and min values should be configurable from the aforementioned file.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Go to a k8s-eks/cluster layer
  2. Change the value for max_capacity
  3. Enter leverage tf apply
  4. No changes are shown

Screenshots

n/a

Environment (please complete the following information):

Anything that will help us triage the bug will help. Here are some ideas:

  • RefArch v1

Additional Context

n/a

@juanmatias juanmatias added the bug Something isn't working label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant