Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken tests #5

Open
cthoyt opened this issue Feb 22, 2018 · 4 comments
Open

Fix broken tests #5

cthoyt opened this issue Feb 22, 2018 · 4 comments
Assignees

Comments

@cthoyt
Copy link
Member

cthoyt commented Feb 22, 2018

Hey we need to figure out what's going on in the tests. One thing to note is that the old artifactory namespace https://arty.scai.fraunhofer.de/artifactory/bel/namespace/human-phenotype-ontology/human-phenotyoe-ontology-YYYYMMDD.belns has been updated to
https://arty.scai.fraunhofer.de/artifactory/bel/namespace/hp/hp-YYYYMMDD.belns

@Cojabi
Copy link
Member

Cojabi commented Jun 7, 2018

when i try to run tox i get 4 errors. Always when creating a Manager due to the lack of an pybel module.

>> from pybel.resources.arty import get_latest_arty_namespace
ImportError: No module named 'pybel.resources.arty'

Did you change something in pybel there?

cthoyt added a commit that referenced this issue Jun 7, 2018
@cthoyt
Copy link
Member Author

cthoyt commented Jun 7, 2018

Since I don't have access to push stuff on Artifactory anymore, I decided it's not a good idea to maintain it as a core feature of PyBEL. I sliced all of those features out to a new repository, pybel-artifactory.

I replaced all of the calls with hard-coded links, centralized in constants.py and removed dependencies. Let me know what you think

@cthoyt
Copy link
Member Author

cthoyt commented Jun 7, 2018

Okay it looks like now we're back to just the one test failing.

@cthoyt
Copy link
Member Author

cthoyt commented Feb 24, 2019

Can we take a look into this again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants