🐛 "useNodejsImportProtocol": "off" Didn't work

[wuchuguang]

VS Code version

1.89.1

Extension version

v2024.5.251958

Biome version

1.8.0

Operating system

• Windows
• macOS
• Linux

Description

my beiome.js code

{
	"$schema": "https://biomejs.dev/schemas/1.8.0/schema.json",
	"organizeImports": {
		"enabled": true
	},
	"linter": {
		"ignore": [
			"**/node_modules/**",
			"**/dist/**",
			"**/build/**",
			"**/run/**",
			"**/test/**"
		],
		"enabled": true,
		"rules": {
			"recommended": true,
			"style": {
				"useNodejsImportProtocol": "off"
			}
		}
	}
}

"useNodejsImportProtocol": "off" Didn't work

Steps to reproduce

1、I configured setting.json as provided by the plugin
2、biome init biome.js config
3、change biome.js like up

Expected behavior

4、Now in my code, I can't use require('path').
5、 npx biome lint is ok.

Does this issue occur when using the CLI directly?

No

Logs

that is all

[wuchuguang]

The biome.js configuration doesn't seem to be working, is vscode-plugin.biome not using biome.js?

[wuchuguang]

[wuchuguang]

[Sec-ant]

The configuration file is biome.json not biome.js.

And where do you put the configuration file?

[wuchuguang]

The configuration file is biome.json not biome.js.

And where do you put the configuration file?

yes, my is biome.json

[wuchuguang]

[ematipico]

Is your configuration at the root of your project? From the look of it, it isn't, that's why it doesn't work.

[wuchuguang]

Is your configuration at the root of your project? From the look of it, it isn't, that's why it doesn't work.

biome.json in my project.

I have multiple projects in my workspace

[wuchuguang]

[Sec-ant]

We have limitations in multi-root workspace support, please check the doc: https://biomejs.dev/reference/vscode/#my-biomejson-file-is-ignored-in-a-multi-root-workspace

[ematipico]

Since v1.8 we support LSP workspaces. Docs are outdated. @wuchuguang can you create a reproduction?

[Sec-ant]

Sorry

[wuchuguang]

s

Since v1.8 we support LSP workspaces. Docs are outdated. @wuchuguang can you create a reproduction?

I'll try using the local LSP

[wuchuguang]

1、my workspace only one project,
2、project/biome.json
3、test.js
const path = require('path') // show biome error
4、test/biome.json
5、 test/test.js
const path = require('path') // show biome error

biome.json

{
    "$schema": "https://biomejs.dev/schemas/1.8.0/schema.json",
    "organizeImports": {
        "enabled": true
    },
    "linter": {
        "enabled": true,
        "rules": {
            "recommended": true,
            "style": {
                "useNodejsImportProtocol": "off"
            }
        }
    }
}

[ematipico]

I believe the issue comes from the extension itself that can't correctly resolve the Biome binary from a workspace project.

This is tracked in: #201