Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Biome warning should be optional #74

Open
GRA0007 opened this issue Jan 11, 2024 · 2 comments
Open

Missing Biome warning should be optional #74

GRA0007 opened this issue Jan 11, 2024 · 2 comments
Labels
Enhancement Improves an existing feature

Comments

@GRA0007
Copy link

GRA0007 commented Jan 11, 2024

I work with several projects and some of them do not (yet!) use Biome. Currently the extension shows this warning every time a project without Biome is loaded:

Could not find Biome in your dependencies. Either add the @biomejs/biome package to your dependencies, or download the Biome binary.

I propose that a biome.warnIfDependencyMissing setting be added that allows disabling this warning, and a "Don't remind me again" option be added to the warning that sets this setting to false.

I'd be happy to work on this if it's something others want 👌

@nhedger
Copy link
Member

nhedger commented Jan 13, 2024

Hey @GRA0007,

Thanks for opening this issue.

We're working on an improved detection mechanism and new options that should solve this issue. I will keep you informed.

@tylerlaprade
Copy link

I came here to report a similar issue with this warning, but triggered in a different context. Since it's similar enough, I'll put it here rather than creating a new issue.

I have Biome specified in my package.json's devDependencies (not dependencies, since it's not needed for the actual app`). Every time I reload the window, I see this warning pop up even though I have Biome in my dependencies.

This was referenced Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improves an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants