Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BismuthWallet instance is created every time BismuthClient is instantiated #6

Open
Endogen opened this issue Jul 10, 2019 · 1 comment
Open

BismuthWallet instance is created every time BismuthClient is instantiated #6

Endogen opened this issue Jul 10, 2019 · 1 comment

Comments

@Endogen
Copy link
Contributor

Endogen commented Jul 10, 2019

In BismuthClient in the __init__()method a BismuthWallet is instantiated by calling self.load_wallet(wallet_file).

That is not necessary if there is no wallet.der file but a wallet.json file.
@hclivess
Copy link
Member

I will add conversion from wallet.der to wallet.json to legacy wallet so we can remove this compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Endogen @hclivess