Custom Nodes documentation

[ecornbower]

The current documentation recommends forking the entire repo and modifying the Dockerfile in order to add custom nodes.

It might be better to recommend creating a new Dockerfile and use the pre-build image as a base. For example:

FROM timpietruskyblibla/runpod-worker-comfy:2.2.0 as base

WORKDIR /comfyui/custom_nodes

# WAS Node Suite
RUN git clone https://github.com/WASasquatch/was-node-suite-comfyui.git ./was
RUN pip install -r ./was/requirements.txt --no-cache-dir

# Go back to the root
WORKDIR /

# Start the container
CMD /start.sh

It's a lot simpler, quicker to build, and easier to update to the latest release.

[billyberkouwer]

I've been following this pattern for installing custom nodes and it does work, however I've found this logged when I run the image. Was still fails to load, although it is installed. Do you have any ideas for how to approach a fix for this, Any help would be much appreciated!

2024-08-01T22:48:54.605832620Z Import times for custom nodes:
2024-08-01T22:48:54.605854420Z    0.0 seconds: /comfyui/custom_nodes/websocket_image_save.py
2024-08-01T22:48:54.605856540Z    0.0 seconds: /comfyui/custom_nodes/comfyui-various
2024-08-01T22:48:54.605858270Z    0.0 seconds: /comfyui/custom_nodes/ComfyUI-Custom-Scripts
2024-08-01T22:48:54.605869639Z    0.0 seconds: /comfyui/custom_nodes/ComfyUI_essentials
2024-08-01T22:48:54.605871529Z    0.1 seconds: /comfyui/custom_nodes/ComfyUI_FizzNodes
2024-08-01T22:48:54.605883159Z    0.3 seconds: /comfyui/custom_nodes/ComfyUI_Comfyroll_CustomNodes
**2024-08-01T22:48:54.605885169Z    0.8 seconds (IMPORT FAILED): /comfyui/custom_nodes/was-node-suite-comfyui**

[ecornbower]

@billyberkouwer Sounds like an issue with WAS since your other nodes are working. I would reach out to them instead. Maybe try loading an older version of WAS and see if they broke something.

[billyberkouwer]

Thank you!

[TimPietrusky]

@ecornbower that sounds like a super good idea! Thank you very much.

Once #30 is done, we hope that custom nodes can also be added with ease.

[LotzF]

@billyberkouwer You're docker container's most likely missing ffmpeg. Docker doesn't have it installed per default and it's not part of the python packages but rather an apt command. Go ahead and install it yourself by altering the apt-get install -y section of the Dockerfile.

WAS requires ffmpeg to work otherwise the import will fail during startup.

Cheers
Leo