Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow images or files input via file urls #57

Open
dannykok opened this issue Aug 8, 2024 · 2 comments
Open

Allow images or files input via file urls #57

dannykok opened this issue Aug 8, 2024 · 2 comments

Comments

@dannykok
Copy link

dannykok commented Aug 8, 2024

I am working on a feature to allow input of files by specifying the URL of the files in the input payload.

Currently, we upload the image using base64 encoding, which they are then serialized through the job dispatching of runpod serverless. However, runpod currently has a limitation on the payload size of 10MB, which prohibits large file input. One way to solve is to instead use remote file URLs in the input payload, and the rp_handler will download the files and re-upload to the Comfy server.

Just to see if you would love this idea, which I could submit a PR later.

@jelling
Copy link

jelling commented Sep 6, 2024

You should be able to do this already without needing this repo to make any changes. When passing the workflow definition, use a node like LoadImagesFromUrl and pass in the image URLs you want as input params.

@dannykok
Copy link
Author

dannykok commented Sep 7, 2024

You should be able to do this already without needing this repo to make any changes. When passing the workflow definition, use a node like LoadImagesFromUrl and pass in the image URLs you want as input params.

Yes you are right. Actually most stuff could be done with nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants