Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incoming file paths are not sanitized #3

Open
blitz opened this issue Dec 8, 2019 · 0 comments
Open

Incoming file paths are not sanitized #3

blitz opened this issue Dec 8, 2019 · 0 comments
Labels
security This issue impacts security
Milestone
Production-ready

Comments

@blitz
Copy link
Owner

blitz commented Dec 8, 2019 •
edited
Loading

Incoming file paths are not sanitized and are basically handed directly to open. This means that any path readable by the user running obiwan is readable via TFTP.

To fix this, parse incoming filenames into directory components and disallow .. escaping the root directory.

Also we need to propagate errors from readFile.
@blitz blitz added the security This issue impacts security label Dec 8, 2019
@blitz blitz added this to the Production-ready milestone Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
security This issue impacts security
Projects
None yet
Milestone
Production-ready
Development

No branches or pull requests
1 participant
@blitz