New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In icon.js error by <use xlink:href="#a"/> #28

Open

astranavt opened this issue Dec 8, 2017 · 2 comments

astranavt commented Dec 8, 2017

How fix this problem?

Contributor

JohnPaulHarold commented Jan 9, 2018

This issue is that React doesn't like it. So you need to replace those with camelCase, which it does like. Such as:

<use xlinkHref="#a"/>

I have the start of a fix for this on this branch
https://github.com/JohnPaulHarold/react-svg-icon-generator/tree/xlinkHref

however, it's far from ready for primetime, or a merge back. It also does some other things I needed doing.

eddiemcleanlux commented May 3, 2018

Any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment