Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warnings on clang-17.0.2 #313

Open
andrewcorrigan opened this issue May 22, 2024 · 1 comment
Open

warnings on clang-17.0.2 #313

andrewcorrigan opened this issue May 22, 2024 · 1 comment
Labels

Comments

@andrewcorrigan
Copy link
Contributor

My last PR, 312, fixed an error I was encountering using MSVC. Unfortunately, this is now triggering warnings on Clang. Would it make sense to add an #if guard and redo my last PR so that we only include the space for compilers that actually require it? This way, MSVC continues to compile and hopefully we could silence warnings from compilers that consider this deprecated?

/third_party/obake/mppp/include/mp++/detail/integer_literals.hpp:410:1: warning: identifier '_z1' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
  410 | MPPP_DECLARE_INTEGRAL_UDL(1)
      | ^
@bluescarni
Copy link
Owner

Would it be possible instead to suppress the specific warning with a pragma or compiler flag for MSVC?

#ifdef-fing would certainly work, but I would like to avoid code repetition if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants