Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance configuration #17

Open
antleblanc opened this issue Feb 4, 2020 · 1 comment
Open

Enhance configuration #17

antleblanc opened this issue Feb 4, 2020 · 1 comment

Comments

@antleblanc
Copy link

Hi!

First thank you for this project!

I've noticed some duplicate informations regarding the configuration.

Here is a suggestion, feel free to give me your feedback.

Before:

{
    "type": "github",
    "repository": "bnjjj/fixme_report",
    "token": "PERSONAL_TOKEN_FROM_GITHUB",
    "username": "bnjjj",
    "url": "https://github.com"
}

After:

{
    "type": "github",
    "repository": "bnjjj/fixme_report",
    "token": "PERSONAL_TOKEN_FROM_GITHUB"
}

Notice that here both username and url are removed because it can be infer from both type AND repository.

See: https://github.com/bnjjj/fixme_report#configuration

@bnjjj
Copy link
Owner

bnjjj commented Feb 6, 2020

Agree for username. But not for the URL. (For example in case of Github enterprise).

By the way, this project just started so it's in their very early stage. So if you find a better way to document, or a better usage feel free. Next step for me is to try and play with github action to make automatic release when I bump version in cargo.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants