From ae30deba12dd129327f1b3bacd1e38eb283de5a4 Mon Sep 17 00:00:00 2001
From: Titouan BION <titouan.bion@booking.com>
Date: Fri, 26 Nov 2021 10:34:17 +0100
Subject: [PATCH] Extend WebhookConfigurations to any apiVersion (#401)

We'd rather fail close on validation that an object unvalidated reach the cluster.
---
 cmd/shipperctl/configurator/cluster.go      | 2 +-
 cmd/shipperctl/configurator/cluster_test.go | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/cmd/shipperctl/configurator/cluster.go b/cmd/shipperctl/configurator/cluster.go
index 4625827c8..2fe3c4f29 100644
--- a/cmd/shipperctl/configurator/cluster.go
+++ b/cmd/shipperctl/configurator/cluster.go
@@ -432,7 +432,7 @@ func (c *Cluster) CreateOrUpdateValidatingWebhookConfiguration(caBundle []byte,
 						},
 						Rule: admissionregistrationv1beta1.Rule{
 							APIGroups:   []string{shipper.SchemeGroupVersion.Group},
-							APIVersions: []string{shipper.SchemeGroupVersion.Version},
+							APIVersions: []string{"*"},
 							Resources:   []string{"*"},
 						},
 					},
diff --git a/cmd/shipperctl/configurator/cluster_test.go b/cmd/shipperctl/configurator/cluster_test.go
index 84f9c6d70..92744011d 100644
--- a/cmd/shipperctl/configurator/cluster_test.go
+++ b/cmd/shipperctl/configurator/cluster_test.go
@@ -175,7 +175,7 @@ func (f *fixture) newValidatingWebhookConfiguration(caBundle []byte, namespace s
 						Operations: operations,
 						Rule: admissionregistrationv1beta1.Rule{
 							APIGroups:   []string{shipper.SchemeGroupVersion.Group},
-							APIVersions: []string{shipper.SchemeGroupVersion.Version},
+							APIVersions: []string{"*"},
 							Resources:   []string{"*"},
 						},
 					},