Popup menu search #916
Popup menu search #916
Conversation
philippfromme
commented
Jun 5, 2024
philippfromme
commented
- adds ability for popup menu providers to provide custom search
- default search sorts matches by location (when searching for "foo", "foo bar" will appear before "bar foo")
|
Example usage here: https://github.com/camunda/camunda-bpmn-js/pull/367/files#diff-1abbb6d8413b72aac12009eae34de187cdc46f9c9eeb5daad527e5c7c43a8df8R23 Not entirely shure if this is the way to do it or wether we should have separate providers for search similar to: https://github.com/bpmn-io/diagram-js/blob/develop/lib/features/search-pad/SearchPadProvider.ts |
lib/features/popup-menu/PopupMenu.js
Outdated
| @@ -557,6 +570,15 @@ PopupMenu.prototype._getEmptyPlaceholder = function(providers) { | |||
| }; | |||
|
|
|||
|
|
|||
| PopupMenu.prototype._getFindEntries = function(providers) { | |||
| const provider = providers.find( | |||
There was a problem hiding this comment.
Not entirely shure if this is the way to do it or wether we should have separate providers for search similar to: https://github.com/bpmn-io/diagram-js/blob/develop/lib/features/search-pad/SearchPadProvider.ts
We should probably use the existing pattern; define a PopupMenuSearchProvider to be overridden as we see fit.
There was a problem hiding this comment.
Even better: Generalize search (can be a follow-up):
- Given a set of objects, search fields
primary: [a], secondary: [b], other: [c](in order of priority) - This way we need to customize the search only once, and re-use across places where it is needed.
There was a problem hiding this comment.
So the idea would be for both the popup menu and the global search to do:
// search available through injector, can be overridden, similar to `translate`
const searchFn = injector.get('search');What do you think?
There was a problem hiding this comment.
I'm happy to sketch this next week.
There was a problem hiding this comment.
Okay, I think this could be a good direction. 👍🏻
philippfromme
force-pushed
the
popup-menu-search
branch
2 times, most recently
from
e62a656
to
5f694ad
Compare
philippfromme
force-pushed
the
popup-menu-search
branch
from
5f694ad
to
03f4e2c
Compare
