Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for structure splitting code #285

Open
dstansby opened this issue Apr 18, 2023 · 1 comment
Open

Add tests for structure splitting code #285

dstansby opened this issue Apr 18, 2023 · 1 comment
Labels
cellfinder-core Issue concerns the core backend enhancement New feature or request

Comments

@dstansby
Copy link
Member

The structure splitting code at https://github.com/brainglobe/cellfinder-core/blob/8d9c0767f81ce66c547a0c0a654c7466cc7e569f/src/cellfinder_core/detect/filters/volume/structure_splitting.py is currently not tested in the test suite. The conditions under which it's called should be determined, and from that some tests added that exercise the code written. It is probably worth tackling #286 first to understand how the code works.
@dstansby dstansby added the enhancement New feature or request label Apr 18, 2023
@adamltyson
Copy link
Member

Yup definitely needed - brainglobe/cellfinder-core#158 has snuck through.

@alessandrofelder alessandrofelder mentioned this issue Apr 28, 2023
Merged
willGraham01 referenced this issue in brainglobe/cellfinder-core Aug 24, 2023
@dstansby
Fix tests (#149)
11e4c8a 
* Fix tox file

* Fix scikit-image dep

* Update pre-commit versions

* Don't fail fast

* Test with xvfb

* Use NI actions
@willGraham01 willGraham01 added the cellfinder-core Issue concerns the core backend label Jan 3, 2024
@willGraham01 willGraham01 transferred this issue from brainglobe/cellfinder-core Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cellfinder-core Issue concerns the core backend enhancement New feature or request
Projects
Core development
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dstansby @adamltyson @willGraham01