From f2f81dcb2d79cd2ced090448ff2491531b0c56f2 Mon Sep 17 00:00:00 2001 From: "Brian M. Adams" Date: Fri, 23 Feb 2018 10:18:19 -0700 Subject: [PATCH] Correct units for "uniform-like proposal" warn Address libqueso/queso#658 by using sqrt(Covariance(i,i)) to compare standard deviation to to domain bounds. --- src/stats/src/TransformedScaledCovMatrixTKGroup.C | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/stats/src/TransformedScaledCovMatrixTKGroup.C b/src/stats/src/TransformedScaledCovMatrixTKGroup.C index 3417db16d..9f472ec56 100644 --- a/src/stats/src/TransformedScaledCovMatrixTKGroup.C +++ b/src/stats/src/TransformedScaledCovMatrixTKGroup.C @@ -327,14 +327,16 @@ TransformedScaledCovMatrixTKGroup::transformCovMatrixToGaussianSpace( double max_val = max_domain_bounds[i]; if (queso_isfinite(min_val) && queso_isfinite(max_val)) { - if (covMatrix(i, i) >= max_val - min_val) { + if (std::sqrt(covMatrix(i, i)) >= max_val - min_val) { // User is trying to specify a uniform proposal distribution, which // is unsupported. Throw an error for now. std::cerr << "Proposal variance element " << i << " is " << covMatrix(i, i) - << " but domain is of size " + << " (standard deviation is " + << std::sqrt(covMatrix(i, i)) + << ") but domain is of size " << max_val - min_val << std::endl; std::cerr << "QUESO does not support uniform-like proposal "