Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the nodes and edges update for single operation #332

Open
Max-ChenFei opened this issue Jul 20, 2023 · 1 comment
Open

Merge the nodes and edges update for single operation #332

Max-ChenFei opened this issue Jul 20, 2023 · 1 comment
Labels
enhancement New feature or request next version Will be fixed in the next version

Comments

@Max-ChenFei
Copy link
Collaborator

Max-ChenFei commented Jul 20, 2023

currently, we use window.requestAnimationFrame to postpone the operation, until the previous nodes are rendered. The correct way should be to change nodes and edges somehow and update the rendering. Also, it is good for undo/redo

Some are async, return promise or add callback to setNodes

https://stackoverflow.com/questions/34687091/can-i-execute-a-function-after-setstate-is-finished-updating

change to class component, add setStates once

@Max-ChenFei Max-ChenFei changed the title Merge the nodes and edges update for single operations Merge the nodes and edges update for single operation Jul 20, 2023
@Max-ChenFei Max-ChenFei added enhancement New feature or request next version Will be fixed in the next version labels Jul 20, 2023
@Max-ChenFei
Copy link
Collaborator Author

refactoring the domain model and interactive reactflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request next version Will be fixed in the next version
Projects
None yet
Development

No branches or pull requests

1 participant