From 88d82dec19f53d37fa383e2f81e23263d0724920 Mon Sep 17 00:00:00 2001 From: Roman Korostinskiy <70313618+c71n93@users.noreply.github.com> Date: Thu, 16 May 2024 17:05:24 +0300 Subject: [PATCH] #3160 add todo for refactoring --- eo-runtime/src/main/java/org/eolang/BytesOf.java | 5 +++++ eo-runtime/src/main/java/org/eolang/Data.java | 4 ++++ 2 files changed, 9 insertions(+) diff --git a/eo-runtime/src/main/java/org/eolang/BytesOf.java b/eo-runtime/src/main/java/org/eolang/BytesOf.java index ec95ae4af8..af6260bd6d 100644 --- a/eo-runtime/src/main/java/org/eolang/BytesOf.java +++ b/eo-runtime/src/main/java/org/eolang/BytesOf.java @@ -31,6 +31,11 @@ * Bytes. * * @since 1.0 + * @todo #3160:90min This class requires refactoring. As a result of refactoring you should remove + * {@code @SuppressWarnings("PMD.GodClass")} from this class and + * {@code @SuppressWarnings("PMD.CognitiveComplexity")} from {@link BytesOf#shift} method. You can + * check description of this rules here + * pmd.github.io */ @Versionized @SuppressWarnings({"PMD.TooManyMethods", "PMD.GodClass"}) diff --git a/eo-runtime/src/main/java/org/eolang/Data.java b/eo-runtime/src/main/java/org/eolang/Data.java index e9c155a2fb..34d042fac0 100644 --- a/eo-runtime/src/main/java/org/eolang/Data.java +++ b/eo-runtime/src/main/java/org/eolang/Data.java @@ -197,6 +197,10 @@ private static Phi toPhi(final Object obj) { * @checkstyle JavaNCSSCheck (100 lines) * @checkstyle NestedIfDepthCheck (100 lines) * @checkstyle ModifiedControlVariableCheck (100 lines) + * @todo #3160:90min This method should be refactored because it has high cognitive + * complexity and other problems. All {@code @checkstyle} warnings suppression and + * {@code SuppressWarnings("PMD.WarningName")} annotations for this method should be + * removed as a result of refactoring. */ @SuppressWarnings({ "PMD.AvoidReassigningLoopVariables",