changed msbuild's withProperty to forward multiple parameters as a co…

…mma separated list
cake-build · Mar 22, 2019 · 95e2547 · 95e2547
1 parent 850bdce
commit 95e2547
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/Cake.Common.Tests/Unit/Tools/MSBuild/MSBuildRunnerTests.cs b/src/Cake.Common.Tests/Unit/Tools/MSBuild/MSBuildRunnerTests.cs
@@ -713,7 +713,7 @@ public void Should_Append_Property_With_Multiple_Values_To_Process_Arguments()
                 var result = fixture.Run();
 
                 // Then
-                Assert.Equal("/v:normal /p:A=B /p:A=E /p:C=D /target:Build " +
+                Assert.Equal("/v:normal /p:A=\"B,E\" /p:C=D /target:Build " +
                              "\"C:/Working/src/Solution.sln\"", result.Args);
             }
 

diff --git a/src/Cake.Common/Tools/MSBuild/MSBuildRunner.cs b/src/Cake.Common/Tools/MSBuild/MSBuildRunner.cs
@@ -275,9 +275,14 @@ private static IEnumerable<string> GetPropertyArguments(IDictionary<string, ILis
         {
             foreach (var propertyKey in properties.Keys)
             {
-                foreach (var propertyValue in properties[propertyKey])
+                if (properties[propertyKey].Count > 1)
                 {
-                    yield return string.Concat("/p:", propertyKey, "=", propertyValue.EscapeMSBuildPropertySpecialCharacters());
+                    var commaSeparatedValues = string.Join(",", properties[propertyKey].Select(x => x.EscapeMSBuildPropertySpecialCharacters()));
+                    yield return string.Concat("/p:", propertyKey, "=", '"', commaSeparatedValues, '"');
+                }
+                else if (properties[propertyKey].Count == 1)
+                {
+                    yield return string.Concat("/p:", propertyKey, "=", properties[propertyKey].First().EscapeMSBuildPropertySpecialCharacters());
                 }
             }
         }