Confirmation of class-dm-rest-domains-controller.php PHP 8.1 Compatibility

[cmcandrew]

Question of whether this is a false positive?

------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------
 455 | ERROR | Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
 461 | ERROR | Extension 'mysql_' is deprecated since PHP 5.5 and removed since PHP 7.0; Use mysqli instead
------------------------------------------------------------------------------------------------------------

[cameronterry]

That would appear to be related to these function calls in the REST API:

dark-matter/domain-mapping/rest/class-dm-rest-domains-controller.php

Lines 452 to 462 in 349538e

	if ( '0000-00-00 00:00:00' === $data['site']['registered'] ) {
	$data['site']['registered'] = null;
	} else {
	$data['site']['registered'] = mysql_to_rfc3339( $data['site']['registered'] );
	}
	if ( '0000-00-00 00:00:00' === $data['site']['last_updated'] ) {
	$data['site']['last_updated'] = null;
	} else {
	$data['site']['last_updated'] = mysql_to_rfc3339( $data['site']['last_updated'] );
	}

Then yes, I believe they are false positives.

As the mysql_to_rfc3339() is part of WordPress Core: https://developer.wordpress.org/reference/functions/mysql_to_rfc3339/