Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we error (or at least log a warning?) if aux methods have ambiguous order? #103

Open
camsaul opened this issue Aug 19, 2022 · 0 comments
Labels
bug Something isn't working high-priority! more important than the other issues

Comments

@camsaul
Copy link
Owner

camsaul commented Aug 19, 2022

If you have two :before methods that are both applicable but neither one is dominant over the other, the order they are applied is indeterminate. This matters for the threading method combinations because they can transform the value. :around methods can transform the value for the CLOS method combination as well (are we already erroring for :around methods?).

We should either error like we do for ambiguous primary methods or at least log a warning (probably just once)

@camsaul camsaul added bug Something isn't working high-priority! more important than the other issues labels Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority! more important than the other issues
Projects
None yet
Development

No branches or pull requests

1 participant