Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clojurescript support #20

Open
darkleaf opened this issue Sep 11, 2019 · 5 comments
Open

Clojurescript support #20

darkleaf opened this issue Sep 11, 2019 · 5 comments
Labels
clojurescript support Issues that we have to tackle in order to get ClojureScript support working. enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@darkleaf
Copy link
Contributor

Hi!
Is it planed to implement clojurescript support?

@darkleaf
Copy link
Contributor Author

I can remove all type hints, deftype+, defprotocol+ and do other stuff.
Yes, it will be slower but we will get cljs support.
I don't know how slower it will be. I can run benchmark.

Will you accept this contribution?

@camsaul
Copy link
Owner

camsaul commented Sep 11, 2019

Hi @darkleaf, that would definitely be a great contribution, and I'd be happy to accept. I wouldn't worry too much about running benchmarks, but making sure we can run tests with ClojureScript is definitely something we would want to do.

@darkleaf
Copy link
Contributor Author

Would your prefer one big patch or many small patches?

@camsaul camsaul added enhancement New feature or request help wanted Extra attention is needed labels Sep 11, 2019
@darkleaf
Copy link
Contributor Author

I want to solve own problem. So I've created library https://github.com/darkleaf/multidecorators
It's small subset of methodical but with clojurescript support.

If you need help, please contact me.

@camsaul camsaul added the clojurescript support Issues that we have to tackle in order to get ClojureScript support working. label Jun 4, 2021
@tekacs
Copy link

tekacs commented Jan 8, 2022

@camsaul is there any chance you might still be interested as you suggested (#25 (comment)) in seeing ClojureScript support in the library?

I'd usually offer to contribute and take a stab at this myself, but methodical is a much hairier library than most and no doubt you have a good handle on what it would take to move over, given the above-mentioned issues.

I'd really like to see the library extended to CLJS, so if it's unlikely you'll get a chance to look for a long time yet then I can take a stab, but I just thought I'd check in first.

Thanks so much for the amazing library!

@camsaul camsaul added this to the 1.0.0 milestone Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clojurescript support Issues that we have to tackle in order to get ClojureScript support working. enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants