Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong centormere coordinates #29

Open
ivan-balashov opened this issue Jan 23, 2024 · 6 comments
Open

Wrong centormere coordinates #29

ivan-balashov opened this issue Jan 23, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@ivan-balashov
Copy link

Hi! thanks for your great package!
Looks like there is an issue with centromere coordinates for some chromosomes in CNAqc::chr_coordinates_GRCh38

image

because if I get them from USCS I've got this
image

You can got same with this command

curl -s "http://hgdownload.cse.ucsc.edu/goldenPath/hg38/database/cytoBand.txt.gz" | gunzip -c | grep acen | sort -V -k1,2 | awk 'BEGIN {print "chromosome\tstart\tend"} {print $1 "\t" $2 "\t" $3}' > centromere.txt

My issue not about exact bases only but there are same start and end of centromere(e.g. chr2 and chr4) which is not good;
Thanks!

@caravagn caravagn added bug Something isn't working question Further information is requested labels Jan 29, 2024
@caravagn
Copy link
Collaborator

Hi, thanks will look into this asap.

@AliceAntonello AliceAntonello self-assigned this Jan 31, 2024
@AliceAntonello
Copy link
Contributor

Hi @ivan-balashov , thank you for raising this issue. The centromere coordinates reported in CNAqc::chr_coordinates_GRCh38 are taken from http://hgdownload.cse.ucsc.edu/goldenPath/hg38/database/centromeres.txt.gz, they differ from the ones you are referring to in the ways they were generated, you can find more details here https://genome.ucsc.edu/cgi-bin/hgTables?db=hg38&hgta_group=map&hgta_track=centromeres&hgta_table=centromeres&hgta_doSchema=describe+table+schema.
We suggest you to directly modify the object if you need another set of coordinates.

@caravagn caravagn added enhancement New feature or request and removed bug Something isn't working question Further information is requested labels Feb 13, 2024
@caravagn
Copy link
Collaborator

Hi @AliceAntonello

Your proposal is not consistent with the current design of CNAqc because it is not possible for a user to modify the centromere coordinates obtained by get_reference

https://github.com/caravagnalab/CNAqc/blob/master/R/get_reference.R

Please think of a way in which this becomes possible (we can add this as a feature). I am changing the issue to enhancment.

@caravagn
Copy link
Collaborator

This might be handled together with adding support for mouse coordinates @vvvirgy. Can you handle it?

You need to

@caravagn
Copy link
Collaborator

Ping @vvvirgy

@caravagn
Copy link
Collaborator

Last time I ping this @vvvirgy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants