Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Trend no longer works correctly #525

Open
jbogaardt opened this issue May 24, 2024 · 0 comments
Open

[BUG] Trend no longer works correctly #525

jbogaardt opened this issue May 24, 2024 · 0 comments
Assignees
Labels

Comments

@jbogaardt
Copy link
Collaborator

Describe the bug
I think a commit flipped start and end in the Triangle.trend method. However, nothing was done to correct the inputs of either the Trend estimator not CapeCod which uses the underlying triangle method, so I believe these are producing inaccurate results. I also think we shouldn't change behavior of existing methods without a formal deprecation. Users will likely have a variety of existing code that relies on the prior approach and they need a lead time to react to this change. I think this needs to be reverted.

Refer to commit efde4a6 for items to be reverted.

@jbogaardt jbogaardt added the Bug label May 24, 2024
@jbogaardt jbogaardt self-assigned this May 24, 2024
jbogaardt pushed a commit that referenced this issue May 24, 2024
jbogaardt pushed a commit that referenced this issue May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant