Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tests runnable on Windows #93

Open
ceejbot opened this issue Dec 17, 2023 · 0 comments
Open

make tests runnable on Windows #93

ceejbot opened this issue Dec 17, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@ceejbot
Copy link
Owner

ceejbot commented Dec 17, 2023

The tests right now depend on a lot of not-windows config conditions, driven by two different considerations. The easy consideration to deal with is replacing game engine functions with test stubs so we don't need a running game but can instead feed functions test fixtures. The slightly more annoying consideration is wide strings and OsStrings in general, because make that switch test vs non-test would mess up Rust analyzer on Macintosh. Since I do most of my development on my Mac laptop, that would suck. Maybe introduce a custom config for running tests on Windows? IDK yet.

I note that the tests need to stay runnable on Linux to keep the Github workflows snappy. It takes forever to spin up anything on a Windows runner.

@ceejbot ceejbot added the enhancement New feature or request label Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant