Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we check this? i.e. rp.EndRow > rp.StartRow. If not, do we want to check this? #1371

Open
rach-id opened this issue Jun 4, 2024 · 0 comments · Fixed by #1372
Open

Do we check this? i.e. rp.EndRow > rp.StartRow. If not, do we want to check this? #1371

rach-id opened this issue Jun 4, 2024 · 0 comments · Fixed by #1372
Assignees
@rach-id

Comments

@rach-id
Copy link
Member

rach-id commented Jun 4, 2024 

          Do we check this? i.e. rp.EndRow > rp.StartRow. If not, do we want to check this?

Originally posted by @cmwaters in #1357 (comment)
@rach-id rach-id self-assigned this Jun 4, 2024
@rach-id rach-id mentioned this issue Jun 4, 2024
Merged
3 tasks
rach-id added a commit that referenced this issue Jun 5, 2024
@rach-id @rootulp
fix: check if row proof end row is greater than start row (#1372)
e580113 
## Description

Closes #1371

#### PR checklist

- [x] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments

---------

Co-authored-by: Rootul P <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rach-id rach-id

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: check if row proof end row is greater than start row celestiaorg/celestia-core
1 participant
@rach-id