Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v0 mempool #1382

Open
ninabarbakadze opened this issue Jun 6, 2024 · 2 comments
Open

Remove v0 mempool #1382

ninabarbakadze opened this issue Jun 6, 2024 · 2 comments

Comments

@ninabarbakadze
Copy link
Member

ninabarbakadze commented Jun 6, 2024

Description

v0 mempool is currently not enabled, therefore we should remove it from the codebase.

@cmwaters
Copy link
Contributor

cmwaters commented Jun 7, 2024

It is currently possible for a node operator to run with the v0 mempool. The original reason for having it around was because the priority mempool itself was new and it was good to have a fallback option. It does seem like the priority mempool has been working well so I would be okay with removing v0 for the purpose of reducing the maintenance burden

@rootulp
Copy link
Collaborator

rootulp commented Jun 7, 2024

Given the implementation is already complete and we're not frequently modifying the v0 implementation, is there a lot of maintenance burden from keeping it?

IMO if we're going to remove support for it, we should deprecate it for some time prior to removing support for it so that node operators see some messaging from us that it will be removed soon and can modify their config to use a different mempool implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants