Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback based on my own CoordinatorLayout implementation #27

Open
grahammendick opened this issue Feb 15, 2020 · 2 comments
Open

Feedback based on my own CoordinatorLayout implementation #27

grahammendick opened this issue Feb 15, 2020 · 2 comments

Comments

@grahammendick
Copy link

Thanks, your project helped me add a collapsing toolbar to my navigation library for React Native. I thought I’d let you know about a couple of things I learnt along the way.

  1. You don’t need your NestedScrollView component because React Native’s ScrollView component supports nested scrolling
  2. The CoordinatorLayout doesn’t work when the scrolled content is too short (height + toolbar height < screen height). It’s because React Native doesn’t bubble the touch event. I intercepted the touch event and manually applied the nested scrolling
@A-ANing
Copy link

A-ANing commented Apr 24, 2020

Is IOS supported @grahammendick

@grahammendick
Copy link
Author

Hey @ngxu, the CoordinatorLayout is native to Android. There's no equivalent UIKit version for iOS.

I built a Twitter example that shows it in action. There's a native collapsing toolbar on the home scene. On the notifications scene, the tabs pin to the top of the screen as the header scrolls off. This is all implemented by wrapping the native functionality on Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants