Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

left/right buttons #5

Open
hl9876 opened this issue Dec 1, 2023 · 0 comments
Open

left/right buttons #5

hl9876 opened this issue Dec 1, 2023 · 0 comments

Comments

@hl9876
Copy link

hl9876 commented Dec 1, 2023

Merhaba! Great app. Found that the on screen left and right buttons (pre-word, next-word) work as expected. But are opposite on keyboard control (line 30 & 33). https://github.com/cevherkarakoc/Speed-Reading/blob/master/src/components/Reader.js#L30

Is this because I am on a left to right text language/browser setting and you are right to left? I would expect on screen left and keyboard left to go backwards/pre-word. On screen right and keyboard right to go forwards/next-word.

Happy to fix this with a PR if it is a typo. Or if this is locale based I can look into a solution.

I'm using English browser.

This is my first issue on GitHub, hope it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant