Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build.sh may be broken on latest Ubuntu #6731

Closed
rhuanjl opened this issue Jul 10, 2021 · 2 comments · Fixed by #6732
Closed

Build.sh may be broken on latest Ubuntu #6731

rhuanjl opened this issue Jul 10, 2021 · 2 comments · Fixed by #6732

Comments

@rhuanjl
Copy link
Collaborator

rhuanjl commented Jul 10, 2021

Whilst it is now possible to build directly with cmake and skip the build.sh script altogether whilst we continue to provide it we should keep it functional...

New versions of Ubuntu ship without Python2.

Build.sh reference to Python2 for optional LLTng support; AND for setting a relative path and this can cause a build failure on Ubuntu 20 - as per @fatcerberus

We should update build.sh to try checking for python 3 if python 2 is not found.

@rhuanjl
Copy link
Collaborator Author

rhuanjl commented Jul 11, 2021

@ppenzin there's also an apparent point that unless you supply a flag to specify Clang, CMake defaults to the system compiler (which on some flavours of linux is gcc) BUT the build fails if you don't use Clang.

So.... building within CMake directly is still slightly awkward AND build.sh is broken on the latest Ubuntu.... ugh.

@ppenzin
Copy link
Member

ppenzin commented Jul 13, 2021

We can reopen if we want to continue working on this, though there is another issue about GCC support (below).

CMake defaults to the system compiler (which on some flavours of linux is gcc) BUT the build fails if you don't use Clang.

GCC is default compiler on all major Linux distros. We have a draft PR by @curtisman for enabling partial GCC support, #6611. Also there is more background on this issue in #2038.

I think we can also add a build to CI that would use build.sh if that is worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants