Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

str.split() returning undesired result with different Line export format #4

Open
chenpionaar1998 opened this issue Aug 12, 2021 · 1 comment

Comments

@chenpionaar1998
Copy link

chenpionaar1998 commented Aug 12, 2021

When the Line messages are exported, they can come in this following format that will cause the code to crash
The individual messages can be in the format of
hh:mm AM/PM name msg example being 7:18 AM test_name this is a test message
In analyze.js line 230 var membername = lines[i].split(/(\s+)/)[2];, the code logic will actually return AM and not test_name
This causes errors in line 231 - 236 which will further cause the code to crash

This might be caused by Line being in a different language setting and not Mandarin like what this app is designed for.
Screen Shot 2021-08-12 at 10 18 10 PM

@chenpionaar1998
Copy link
Author

Actually, there seems to be a PR addressing this. This might not be needed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant