From 9e46db18845f449e907066cda57258ca8806039e Mon Sep 17 00:00:00 2001 From: Max Harmony Date: Wed, 25 Nov 2020 18:17:23 -0500 Subject: [PATCH 1/2] clarify ""Max-age > 10 years" warning --- header.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/header.go b/header.go index 0c59669..0a2f96b 100644 --- a/header.go +++ b/header.go @@ -242,7 +242,7 @@ func preloadableHeaderMaxAge(hstsHeader HSTSHeader) Issues { issues = issues.addWarningf( "header.preloadable.max_age.over_10_years", "Max-age > 10 years", - "FYI: The max-age (%d seconds) is longer than 10 years, which is an unusually long value.", + "FYI: The max-age (%d seconds) is longer than 10 years, which is an unusually long value, and may be disregarded by some browsers.", hstsHeader.MaxAge.Seconds, ) From cdfccb4f8984651a8df4a9aa48487f2de7a5d727 Mon Sep 17 00:00:00 2001 From: Max Harmony Date: Thu, 26 Nov 2020 12:48:11 -0500 Subject: [PATCH 2/2] revision per discussion on pr --- header.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/header.go b/header.go index 0a2f96b..e8287a5 100644 --- a/header.go +++ b/header.go @@ -242,7 +242,7 @@ func preloadableHeaderMaxAge(hstsHeader HSTSHeader) Issues { issues = issues.addWarningf( "header.preloadable.max_age.over_10_years", "Max-age > 10 years", - "FYI: The max-age (%d seconds) is longer than 10 years, which is an unusually long value, and may be disregarded by some browsers.", + "FYI: The max-age (%d seconds) is longer than 10 years, which is an unusually long value, and may be capped to a lower value in some browsers.", hstsHeader.MaxAge.Seconds, )