Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: import only once #5

Open
dirkroorda opened this issue Sep 13, 2013 · 1 comment
Open

Dependencies: import only once #5

dirkroorda opened this issue Sep 13, 2013 · 1 comment
Assignees
Labels

Comments

@dirkroorda
Copy link

When resolving dependencies, dependent files should be imported only once, otherwise it may cause siginificant overhead. It also prevents problems with cyclic dependencies, e.g. when one file has the regions and edges, and another the nodes.

By the way: when you feed the files in the right order, dependency information does not have to be given in de annotation files.
So if your files are an acyclic graph with respect to dependency, you can just feed them in the right order without any dependency statements.

Nevertheless it is better to be able to state dependencies correctly without incurring performance penalties.

Currently graf-python works in such a way that when A is dependent on B and B on C, it is not necessary to state the dependency of A on C.
To me this seems natural, and I hope this will not be changed when you modify the dependency handling.

Here is a LAF resource with the kind of dependencies that led me to write this issue.
https://www.dropbox.com/sh/om42p6ai691eo52/h2g0yItKvy
I have truncated everything to the first 100 nodes to keep everything managable.
I also add a script I used to call graf-python on this resource.

By the way: on
https://graf-python.readthedocs.org/en/latest/Parsing%20GrAF.html
it says:
for node in graph.nodes():
But that should be
for node in graph.nodes:

@pbouda
Copy link

pbouda commented Aug 22, 2014

The example files are on our ownCloud in Poio/ExampleFiles/Dirk/result_latest.zip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants